program exit..

Here you can report bugs you may find in ShellEnhancer.

Moderators: Marc G, Johan G

program exit..

Postby ltwally » Tue Sep 26, 2006 6:57 pm

This program, by default, does not un-hook itself upon exit. Why would you do such a thing? From a programmer's perspective, that is a horrible decision. From the end-user's perspective, that is a horrible decision. You've ensured that the OS becomes unresponsive and unstable when ShellEnhancer exits (either by user termination or program crashing). It's not that difficult to remove your hooks in exit() !!! If you want the option to not remove the hooks, you could at least NOT make it the default!

I'll never touch any software from this company again, purely for the reason of seeing such an obvious and stupid mistake speaks miles about the quality of your code.
ltwally
 

Postby Marc G » Wed Sep 27, 2006 10:17 am

How did you come to the conclusion that the hooks are not removed?

All the hooks are properly unhooked at program exit.
What remains is that the currently open windows will remain subclassed for a while, until a moment at which time it is safe to unsubclass the window. This is unfortunately the way it works in Windows and is nothing we can do about. For example: if notepad is being subclassed by SE and has a dialog open, it is unsafe to unsubclass the notepad window because when the open dialog is closed afterwards, notepad will crash because a window procedure was removed from the chain.
Marc Gregoire,
NuonSoft
[ Microsoft MVP VC++ since 2007 ]
User avatar
Marc G
NuonSoft Staff
 
Posts: 826
Joined: Thu Nov 07, 2002 8:19 pm
Location: Belgium

Postby Marc G » Thu Sep 28, 2006 7:51 am

Also note that for the next version I'm rewritting the backend of SE which will use new functionality from Windows XP to make subclassing windows from other processes more safe than the currently implemented mechanism.
Marc Gregoire,
NuonSoft
[ Microsoft MVP VC++ since 2007 ]
User avatar
Marc G
NuonSoft Staff
 
Posts: 826
Joined: Thu Nov 07, 2002 8:19 pm
Location: Belgium


Return to SE - Bug Reports

Who is online

Users browsing this forum: No registered users and 1 guest

cron